feat: default ADDRESS env var on deploy #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests that deployed functions listen on all interfaces by default by providing an ADDRESS environment variable.
knative-prow
bot
added
kind/enhancement
size/M
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1837 +/- ##
==========================================
+ Coverage 62.51% 63.53% +1.02%
==========================================
Files 107 107
Lines 13732 13749 +17
==========================================
+ Hits 8585 8736 +151
+ Misses 4331 4172 -159
- Partials 816 841 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lkingland
requested review from
lance,
salaboy,
zroubalik,
aslom and
matejvasek
and removed request for
maximilien and
navidshaikh
zroubalik
approved these changes
Jul 4, 2023
knative-prow
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lance
reviewed
Jul 6, 2023
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtimes should, by default, only listen on the loopback interface for security (they may be
func runlocally).The ADDRESS environment variable added here on deploy requests the runtime to listen on all interfaces (0.0.0.0) when deployed, since they will need to listen for client requests and for health readiness/liveness probes.
Additionally, now a user who wishes to securely open their function to only receive requests on a specific interface, such as a WireGuard-encrypted mesh network which presents as a specific interface; that can be achieved by explicitly setting the ADDRESS on their function.
NOTE this env variable is only a suggestion, and it is up to the runtimes to read and use. This is currently respected by scaffolded Go functions (
func-runtime-golibrary), with other runtimes expected to implement as they are updated to support scaffolding./kind enhancement