Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/webhook: refactor Propagation Policy test #5537

Merged

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Sep 13, 2024

Description

In this commit, we refactor propagation policy names and check on number of patches after the mutation happens.

Motivation and Context

Motivated by @XiShanYongYe-Chang's comment #5494 (comment).

What type of PR is this?

/kind cleanup

Which issue(s) this PR fixes:
Follow-up on #5492.

Does this PR introduce a user-facing change?:

NONE

In this commit, we refactor propagation policy names and check
on number of patches the mutation happens.

Signed-off-by: Mohamed Awnallah <[email protected]>
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 13, 2024
@mohamedawnallah mohamedawnallah changed the title pkg/webhook: refactor propagation policy pkg/webhook: refactor propagation policy test Sep 13, 2024
@mohamedawnallah mohamedawnallah changed the title pkg/webhook: refactor propagation policy test pkg/webhook: refactor Propagation Policy test Sep 13, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.86%. Comparing base (671372a) to head (368b4b1).
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5537      +/-   ##
==========================================
+ Coverage   33.71%   33.86%   +0.15%     
==========================================
  Files         643      643              
  Lines       44500    44509       +9     
==========================================
+ Hits        15001    15071      +70     
+ Misses      28357    28289      -68     
- Partials     1142     1149       +7     
Flag Coverage Δ
unittests 33.86% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@karmada-bot karmada-bot merged commit c3d582b into karmada-io:master Sep 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants