Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/webhook: refactor Propagation Policy test #5537

Merged
merged 1 commit into from
Sep 13, 2024
Merged

pkg/webhook: refactor Propagation Policy test #5537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions pkg/webhook/propagationpolicy/mutating_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ func TestMutatingAdmission_Handle(t *testing.T) {
}

func TestMutatingAdmission_Handle_FullCoverage(t *testing.T) {
// Define the policy name and namespace to be used in the test.
policyName := "test-policy"
// Define the pp name and namespace to be used in the test.
policyName := "test-propagation-policy"
namespace := "test-namespace"

// Mock a request with a specific namespace.
Expand All @@ -113,8 +113,8 @@ func TestMutatingAdmission_Handle_FullCoverage(t *testing.T) {
},
}

// Create the initial policy with default values for testing.
policy := &policyv1alpha1.PropagationPolicy{
// Create the initial pp with default values for testing.
pp := &policyv1alpha1.PropagationPolicy{
ObjectMeta: metav1.ObjectMeta{
Name: policyName,
},
Expand Down Expand Up @@ -145,8 +145,8 @@ func TestMutatingAdmission_Handle_FullCoverage(t *testing.T) {
},
}

// Define the expected policy after mutations.
wantPolicy := &policyv1alpha1.PropagationPolicy{
// Define the expected pp after mutations.
wantPP := &policyv1alpha1.PropagationPolicy{
ObjectMeta: metav1.ObjectMeta{
Name: policyName,
Labels: map[string]string{
Expand Down Expand Up @@ -189,15 +189,15 @@ func TestMutatingAdmission_Handle_FullCoverage(t *testing.T) {
},
}

// Mock decoder that decodes the request into the policy object.
// Mock decoder that decodes the request into the pp object.
decoder := &fakeMutationDecoder{
obj: policy,
obj: pp,
}

// Marshal the expected policy to simulate the final mutated object.
wantBytes, err := json.Marshal(wantPolicy)
// Marshal the expected pp to simulate the final mutated object.
wantBytes, err := json.Marshal(wantPP)
if err != nil {
t.Fatalf("Failed to marshal expected policy: %v", err)
t.Fatalf("Failed to marshal expected propagation policy: %v", err)
}
req.Object.Raw = wantBytes

Expand All @@ -209,12 +209,16 @@ func TestMutatingAdmission_Handle_FullCoverage(t *testing.T) {
// Call the Handle function.
got := mutatingHandler.Handle(context.Background(), req)

// Verify that the only patch applied is for the UUID label. If any other patches are present, it indicates that the policy was not handled as expected.
if len(got.Patches) > 0 {
firstPatch := got.Patches[0]
if firstPatch.Operation != "replace" || firstPatch.Path != "/metadata/labels/propagationpolicy.karmada.io~1permanent-id" {
t.Errorf("Handle() returned unexpected patches. Only the UUID patch was expected. Received patches: %v", got.Patches)
}
// Check if exactly one patch is applied.
if len(got.Patches) != 1 {
t.Errorf("Handle() returned an unexpected number of patches. Expected one patch, received: %v", got.Patches)
}

// Verify that the only patch applied is for the UUID label
// If any other patches are present, it indicates that the propagation policy was not handled as expected.
firstPatch := got.Patches[0]
if firstPatch.Operation != "replace" || firstPatch.Path != "/metadata/labels/propagationpolicy.karmada.io~1permanent-id" {
t.Errorf("Handle() returned unexpected patches. Only the UUID patch was expected. Received patches: %v", got.Patches)
}

// Check if the admission request was allowed.
Expand Down