Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appdata related patches #1114

Merged
merged 4 commits into from Nov 14, 2023
Merged

Appdata related patches #1114

merged 4 commits into from Nov 14, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 13, 2023

appdata: Use appstreamcli for appdata validation

appstream-util is obsoleted by appstreamcli.

data: Mark two strings as untranslatable

Mark the developer name and the application name as untranslatable.

appdata: Update appdata

  • Remove one of Purism tag to pass validation
  • Add the launchable tag
  • Add translate URL
  • Add keywords and categories that in use GNOME Software and KDE Discover

appdata: Use longer sentence for app description](appdata: Use longer sentence for app description

Fix appstreamcli warning

"Foliate is modern e-book reader app designed for GNOME.
The first description/p paragraph of this component might be too short (< 80 characters). Please consider starting with a longer paragraph to improve how the description looks like in software centers and to provide more detailed information on this component immediately"

Sabri Ünal added 3 commits November 13, 2023 19:15
appstream-util is obsoleted by appstreamcli.
Mark the developer name and the application name as untranslatable.
- Remove one of Purism tag to pass validation
- Add the launchable tag
- Add translate URL
- Add keywords and categories that in use GNOME Software and KDE Discover
@johnfactotum
Copy link
Owner

Mark the developer name and the application name as untranslatable.

IMHO, whether names are translated depends on the locale and should be left to the discretion of the translator.

Generally speaking, it's not uncommon to transcribe or translate names, especially when the target language is in a different writing system.

Add keywords and categories that in use GNOME Software and KDE Discover

Do they not pull those from the desktop file if there's a <launchable> ?

Use longer sentence for app description

The current description is indeed not that great. But I must say I'm not really happy with the new version, either.

@ghost
Copy link
Author

ghost commented Nov 13, 2023

Add keywords and categories that in use GNOME Software and KDE Discover

Do they not pull those from the desktop file if there's a <launchable> ?

Seems a bit backwards compatibility but yes both of them support.

But the 'keywords' tag is official

Mark the developer name and the application name as untranslatable.

IMHO, whether names are translated depends on the locale and should be left to the discretion of the translator.

Generally speaking, it's not uncommon to transcribe or translate names, especially when the target language is in a different writing system.

I think your name is written in Latin. Yes, translatable names are useful for Arabic, Chinese, Japanese, etc., names.

The current description is indeed not that great. But I must say I'm not really happy with the new version, either.

Some alternatives as suggestion:

  • Foliate is a modern e-book reader app designed for GNOME and is capable of opening EPUB, Mobipocket, Kindle, FB2, CBZ, and PDF files.

  • Foliate is a modern e-book reader app designed for GNOME. From EPUB to PDF, enjoy personalized reading with themes, bookmarks, and quick lookup.

  • Foliate is a modern e-book reader app designed for GNOME. From EPUB to PDF, enjoy personalized reading.

@johnfactotum
Copy link
Owner

Hmm. I guess the engaging tone of "Dive into a literary journey with Foliate..." does sound better. But maybe de-emphasize specific features as those are listed below. How about

Discover a new chapter in reading with Foliate, the modern e-book reader tailored for GNOME. Immerse yourself in a distraction-free interface, with customization features designed to match your unique preferences.

Fix appstreamcli warning

"Foliate is modern e-book reader app designed for GNOME.

The first `description/p` paragraph of this component might be
too short (< 80 characters). Please consider starting with a longer
paragraph to improve how the description looks like in software centers
and to provide more detailed information on this component immediately
in the first paragraph."
@ghost
Copy link
Author

ghost commented Nov 14, 2023

Hmm. I guess the engaging tone of "Dive into a literary journey with Foliate..." does sound better. But maybe de-emphasize specific features as those are listed below. How about

Discover a new chapter in reading with Foliate, the modern e-book reader tailored for GNOME. Immerse yourself in a distraction-free interface, with customization features designed to match your unique preferences.

Updated.

@johnfactotum
Copy link
Owner

Thanks!

@johnfactotum johnfactotum merged commit 9d0f0e1 into johnfactotum:gtk4 Nov 14, 2023
2 checks passed
@ghost ghost deleted the fix-appstreamcli branch January 16, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant