Skip to content

Commit

Permalink
AppData related patches (#1114)
Browse files Browse the repository at this point in the history
- appstream-util is obsoleted by appstreamcli
- Mark names as untranslatable
- Remove one of Purism tag to pass validation
- Add the launchable tag
- Add translate URL
- Add keywords and categories
- Use longer sentence for app description
  • Loading branch information
Sabri Ünal committed Nov 14, 2023
1 parent 1e89118 commit 9d0f0e1
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 8 deletions.
1 change: 1 addition & 0 deletions data/com.github.johnfactotum.Foliate.desktop.in
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[Desktop Entry]
# Translators: Do NOT translate! The is the application name!
Name=Foliate
GenericName=E-Book Viewer
Comment=Read e-books in style
Expand Down
20 changes: 16 additions & 4 deletions data/com.github.johnfactotum.Foliate.metainfo.xml.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
<id>com.github.johnfactotum.Foliate</id>
<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-3.0-or-later</project_license>
<name>Foliate</name>
<name translate="no">Foliate</name>
<summary>Read e-books in style</summary>
<translation type="gettext">com.github.johnfactotum.Foliate</translation>
<description>
<p>Foliate is modern e-book reader app designed for GNOME.</p>
<p>Discover a new chapter in reading with Foliate, the modern e-book reader tailored for GNOME. Immerse yourself in a distraction-free interface, with customization features designed to match your unique preferences.</p>
<p>Features include:</p>
<ul>
<li>Open EPUB, Mobipocket, Kindle, FB2, CBZ, and PDF files</li>
Expand All @@ -20,10 +20,23 @@
<li>Quick dictionary lookup</li>
</ul>
</description>
<developer_name>John Factotum</developer_name>
<developer_name translate="no">John Factotum</developer_name>
<launchable type="desktop-id">com.github.johnfactotum.Foliate.desktop</launchable>
<categories>
<category>Office</category>
<category>Viewer</category>
</categories>
<keywords>
<keyword>Book</keyword>
<keyword>EPUB</keyword>
<keyword>Ebook</keyword>
<keyword>Reader</keyword>
<keyword>Viewer</keyword>
</keywords>
<url type="homepage">https://johnfactotum.github.io/foliate/</url>
<url type="vcs-browser">https://github.com/johnfactotum/foliate</url>
<url type="bugtracker">https://github.com/johnfactotum/foliate/issues</url>
<url type="translate">https://github.com/johnfactotum/foliate/tree/gtk4/po</url>
<url type="faq">https://github.com/johnfactotum/foliate/blob/gtk4/docs/faq.md</url>
<url type="donation">https://www.buymeacoffee.com/johnfactotum</url>
<screenshots>
Expand Down Expand Up @@ -52,7 +65,6 @@
</releases>
<content_rating type="oars-1.1" />
<custom>
<value key="Purism::form_factor">workstation</value>
<value key="Purism::form_factor">mobile</value>
</custom>
</component>
8 changes: 4 additions & 4 deletions data/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ appstream_file = i18n.merge_file(
install_dir: join_paths(get_option('datadir'), 'metainfo')
)

appstream_util = find_program('appstream-util', required: false)
if appstream_util.found()
test('Validate appstream file', appstream_util,
args: ['validate', appstream_file]
appstreamcli = find_program('appstreamcli', required: false)
if appstreamcli.found()
test('Validate appstream file', appstreamcli,
args: ['validate', '--no-net', appstream_file]
)
endif

Expand Down

0 comments on commit 9d0f0e1

Please sign in to comment.