Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner children are visibly hidden - Resolve Issue #20 #21

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Spinner children are visibly hidden - Resolve Issue #20 #21

merged 1 commit into from
Jul 24, 2023

Conversation

isosphere
Copy link
Owner

Resolution for #20:

  • Use Spinner component's children to populate the "visibly-hidden" span
  • Eliminate text property

@isosphere isosphere mentioned this pull request Jul 21, 2023
Closed
@Kritzefitz
Copy link

Looks good to me!

Thanks for providing a fix this soon.

@isosphere isosphere merged commit f56007d into main Jul 24, 2023
1 check passed
@isosphere isosphere deleted the issue-20 branch July 24, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isosphere @Kritzefitz