Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner hidden text not working as documented #20

Closed
Kritzefitz opened this issue Jul 19, 2023 · 2 comments
Closed

Spinner hidden text not working as documented #20

Kritzefitz opened this issue Jul 19, 2023 · 2 comments
Assignees

Comments

@Kritzefitz
Copy link

The documentation of yew_bootstrap::component::Spinner says that visually hidden text in the spinner should be added as follows:

<Spinner>
  {"hidden text"}
</Spinner>

However, that example renders like this:

image

Looking at the source of the Spinner component

        html! {
            <div class={classes} role="status">
                <span class="visually-hidden">
                    {&props.text}
                </span>
                { for props.children.iter() }
            </div>
        }

it looks like the text attribute is actually rendered where the hidden text would be supposed to be rendered. But since its type is bool it can't really be used to pass any useful state either.

@isosphere
Copy link
Owner

Thank you for your report @Kritzefitz , I can confirm your findings.

Please check out #21 for my proposed solution and let me know if it meets your needs.

@isosphere
Copy link
Owner

isosphere commented Jul 24, 2023

Closed as completed! Fixed in 0.5.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants