Add CI #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ jgrpp ] | ||
| pull_request: | ||
| branches: [ jgrpp ] | ||
|
|
||
| jobs: | ||
| build_linux: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: prepare workspace | ||
| run: mkdir build | ||
| - name: install dependencies | ||
| run: "sudo apt-get install -y zlib1g-dev liblzo2-dev liblzma-dev libpng-dev libfreetype6-dev libfontconfig1-dev libicu-dev libsdl2-dev" | ||
| - name: cmake | ||
| run: | | ||
| pushd build | ||
| cmake .. | ||
| popd | ||
| - name: make package | ||
| run: | | ||
| pushd build | ||
| make package | ||
| popd | ||
| - name: upload artifact | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: linux | ||
| path: build/bundles/* | ||
|
|
||
| build_macos: | ||
| runs-on: macos-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: prepare workspace | ||
| run: mkdir build | ||
| - name: brew update | ||
| run: "brew update" | ||
| - name: install dependencies | ||
| run: "brew install zlib lzo xz libpng freetype fontconfig icu4c sdl2" | ||
|
There was a problem hiding this comment. I was having some difficulties compiling a version of this for Enjineer a few months ago, brew seemed to be installing only dynamic libs. The executable works on my machine because I have the libraries installed, but I'm thinking this might not work for people who don't have these libraries installed. I have access to a non-brew'ed machine, so I'll give it a test later today. There was a problem hiding this comment. hm yeah, i'm not sure how to get homebrew to use static libs There was a problem hiding this comment. and i have a feeling the same issue will happen with linux |
||
| - name: cmake | ||
| run: | | ||
| pushd build | ||
| cmake .. | ||
| popd | ||
| - name: make package | ||
| run: | | ||
| pushd build | ||
| make package | ||
| popd | ||
| - name: upload artifact | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: macOS | ||
| path: build/bundles/* | ||
|
|
||
| build_windows: | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: prepare workspace | ||
| run: mkdir build | ||
| - name: set up vcpkg and install dependencies # should probably cache this but whatever | ||
| run: | | ||
| git clone --depth 1 https://github.com/Microsoft/vcpkg.git | ||
| pushd vcpkg | ||
| .\bootstrap-vcpkg.bat | ||
| .\vcpkg.exe install liblzma:x64-windows-static libpng:x64-windows-static lzo:x64-windows-static zlib:x64-windows-static | ||
| popd | ||
| - name: cmake | ||
| run: | | ||
| pushd build | ||
| cmake.exe .. -G'Visual Studio 16 2019' -DCMAKE_TOOLCHAIN_FILE="..\vcpkg\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET="x64-windows-static" | ||
| popd | ||
| - name: make package | ||
| run: | | ||
| pushd build | ||
| cmake.exe --build . --target PACKAGE --config RelWithDebInfo | ||
| popd | ||
| - name: upload artifact | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: win64 | ||
| path: build/bundles/* | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was testing this build, did not work for me. Its complaining about how it can't find the OpenGFX set, even though I have it installed. When I tried running the executable inside the package directly (vs running as the
.appfolder) it worked 😕 . Maybe it's some weird new macOS security thing? I'm on vacation right now so sadly I don't have a ton of time to look into this, but I'll see what I can do!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's possible you will need to de-quarantine it yeah. the "simplest" way i found in the past was to
xattr -r -d com.apple.quarantine ~/Downloads/bundle.app, but iirc you can also command click it to get the gatekeeper prompt. it's also possible you'll need to change the security setting to allow unsigned apps or downloaded apps to runThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not much we can do about it from this end without a signing key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's also possible of course that this is not the problem at all. i can test this on a vm later