Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #1

Open
wants to merge 5 commits into
base: jgrpp
Choose a base branch
from
Open

Add CI #1

wants to merge 5 commits into from

Conversation

HotelCalifornia
Copy link
Member

github actions pipeline for any commits on jgrpp or pull requests that target jgrpp

@HotelCalifornia HotelCalifornia force-pushed the feature/ci branch 2 times, most recently from 735a445 to c35e164 Compare July 7, 2020 05:17
Fix: apt and homebrew CI commands

Fix: update bundles location
name: linux
path: build/bundles/*

build_macos:
Copy link

@BasicBeluga BasicBeluga Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was testing this build, did not work for me. Its complaining about how it can't find the OpenGFX set, even though I have it installed. When I tried running the executable inside the package directly (vs running as the .app folder) it worked 😕 . Maybe it's some weird new macOS security thing? I'm on vacation right now so sadly I don't have a ton of time to look into this, but I'll see what I can do!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possible you will need to de-quarantine it yeah. the "simplest" way i found in the past was to xattr -r -d com.apple.quarantine ~/Downloads/bundle.app, but iirc you can also command click it to get the gatekeeper prompt. it's also possible you'll need to change the security setting to allow unsigned apps or downloaded apps to run

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not much we can do about it from this end without a signing key

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's also possible of course that this is not the problem at all. i can test this on a vm later

- name: brew update
run: "brew update"
- name: install dependencies
run: "brew install zlib lzo xz libpng freetype fontconfig icu4c sdl2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having some difficulties compiling a version of this for Enjineer a few months ago, brew seemed to be installing only dynamic libs. The executable works on my machine because I have the libraries installed, but I'm thinking this might not work for people who don't have these libraries installed. I have access to a non-brew'ed machine, so I'll give it a test later today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm yeah, i'm not sure how to get homebrew to use static libs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i have a feeling the same issue will happen with linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants