-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI #1
base: jgrpp
Are you sure you want to change the base?
Add CI #1
Conversation
735a445
to
c35e164
Compare
c35e164
to
1abf257
Compare
name: linux | ||
path: build/bundles/* | ||
|
||
build_macos: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was testing this build, did not work for me. Its complaining about how it can't find the OpenGFX set, even though I have it installed. When I tried running the executable inside the package directly (vs running as the .app
folder) it worked 😕 . Maybe it's some weird new macOS security thing? I'm on vacation right now so sadly I don't have a ton of time to look into this, but I'll see what I can do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's possible you will need to de-quarantine it yeah. the "simplest" way i found in the past was to xattr -r -d com.apple.quarantine ~/Downloads/bundle.app
, but iirc you can also command click it to get the gatekeeper prompt. it's also possible you'll need to change the security setting to allow unsigned apps or downloaded apps to run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not much we can do about it from this end without a signing key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's also possible of course that this is not the problem at all. i can test this on a vm later
- name: brew update | ||
run: "brew update" | ||
- name: install dependencies | ||
run: "brew install zlib lzo xz libpng freetype fontconfig icu4c sdl2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having some difficulties compiling a version of this for Enjineer a few months ago, brew seemed to be installing only dynamic libs. The executable works on my machine because I have the libraries installed, but I'm thinking this might not work for people who don't have these libraries installed. I have access to a non-brew'ed machine, so I'll give it a test later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm yeah, i'm not sure how to get homebrew to use static libs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and i have a feeling the same issue will happen with linux
github actions pipeline for any commits on jgrpp or pull requests that target jgrpp