-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for linked verifiable presentations #92
Draft
nanderstabel
wants to merge
48
commits into
dev
Choose a base branch
from
feat/linked-vp
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,433
−1,035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
changed the title
WIP
feat: add support for linked verifiable presentations
Sep 12, 2024
nanderstabel
force-pushed
the
feat/linked-vp
branch
from
September 18, 2024 15:05
ec7b099
to
0cabb68
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds (dynamic) Linked Verifiable Presentation support to UniCore
Links to any relevant issues
How the change has been tested
The updated Postman Collection can be used to test this added functionality manually:
make sure did web and domain linkage are enabled (and preferred) in the config (or .env) file:
Issuance:
Holder:
3. execute Holder/offers (the Offer sent by the Issuer should be returned in the Response)
4. execute Holder/offers_accept
5. execute Holder/credentials (copy the
credential_id
value in the response)6. execute POST Holder/presentations (paste the
credential_id
value in the array in the Request Body, copy thepresentation_id
value that is returned in the Response)Identity:
7. execute Identity/linked-vp (paste the
presentation_id
value in the array in the Request BodyTo check whether the linked VP was successfully added, execute .well-known/did:web. You should see that two services are added to the Document, one of them has the LinkedVerifiablePresentation type. The serviceEndpoint should be pointing at the endpoint where the Linked VP is hosted
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.