feat: Add third-party issuer validation during SIOP auth request #256
+1,106
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiertech
changed the title
maiertech
changed the title
…#259) Bumps [prettier-plugin-tailwindcss](https://github.com/tailwindlabs/prettier-plugin-tailwindcss) from 0.6.1 to 0.6.5. - [Release notes](https://github.com/tailwindlabs/prettier-plugin-tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/prettier-plugin-tailwindcss/blob/main/CHANGELOG.md) - [Commits](tailwindlabs/prettier-plugin-tailwindcss@v0.6.1...v0.6.5) --- updated-dependencies: - dependency-name: prettier-plugin-tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@ianvs/prettier-plugin-sort-imports](https://github.com/ianvs/prettier-plugin-sort-imports) from 4.2.1 to 4.3.0. - [Release notes](https://github.com/ianvs/prettier-plugin-sort-imports/releases) - [Changelog](https://github.com/IanVS/prettier-plugin-sort-imports/blob/main/CHANGELOG.md) - [Commits](IanVS/prettier-plugin-sort-imports@v4.2.1...v4.3.0) --- updated-dependencies: - dependency-name: "@ianvs/prettier-plugin-sort-imports" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [prettier-plugin-svelte](https://github.com/sveltejs/prettier-plugin-svelte) from 3.2.3 to 3.2.5. - [Changelog](https://github.com/sveltejs/prettier-plugin-svelte/blob/master/CHANGELOG.md) - [Commits](sveltejs/prettier-plugin-svelte@v3.2.3...v3.2.5) --- updated-dependencies: - dependency-name: prettier-plugin-svelte dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nander Stabel <[email protected]>
Bumps [prettier](https://github.com/prettier/prettier) from 3.3.0 to 3.3.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.3.0...3.3.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
daniel-mader
added
the
Blocked
maiertech
added a commit
that referenced
this pull request
Jul 19, 2024
6 tasks
maiertech
added a commit
that referenced
this pull request
Jul 19, 2024
maiertech
added a commit
that referenced
this pull request
Jul 23, 2024
maiertech
added a commit
that referenced
this pull request
Jul 23, 2024
* Changes that are stuck in #256 * Update `empty_state` in store * Fix more TS errors
|
Putting this back into Draft again since I now have the time to make the backend part of this PR more generic. |
3 tasks
nanderstabel
force-pushed
the
feat/linked-vp
branch
from
ddf1e78
to
bad8844
Compare
|
This PR is now updated to support 'generic' linked VPs. Please check the description for testing instructions :) |
maiertech
reviewed
Sep 19, 2024
|
|
||
| import Check from '~icons/ph/check-bold'; | ||
| import QuestionMark from '~icons/ph/question-mark-bold'; | ||
| import X from '~icons/ph/x-bold'; |
There was a problem hiding this comment.
Replace icon imports with
import {CheckBoldIcon, QUestionMarkBoldIcon, XBoldIcon} from '$lib/icons';
This was part of a refactoring done while the PR was pending.
maiertech
requested changes
Sep 19, 2024
daniel-mader
removed
the
Blocked
Oran-Dan
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This feature adds a demo validation of a credential issued by a third-party issuer. The check is done during a SIOP auth request. Visual feedback with issuer logo and checkmark.
Links to any relevant issues
this change is needed for:
How the change has been tested
Unit tests added in
identity-wallet/src/state/did/validate_linked_verifiable_presentations.rsThis functionality can be manually tested against this UniCore branch. Please follow the test instructions there under "How the change has been tested" to spin up a UniCore instance and add a Linked Verifiable Presentation to it.
After setting up the UniCore instance, execute the Verification/siopv2_authorization_requests Request to obtain the Authorization Request string. Copy Paste this string in UniMe (in devmode) to see the result.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.