Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add static as return type of BaseObject fromArray method #45

Merged
merged 1 commit into from
Jul 30, 2023
Merged

feat: add static as return type of BaseObject fromArray method #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/Object/BaseObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,7 @@ public function jsonSerialize(): mixed
return $dataToSerialize;
}

/**
* @todo: set return type to static when PHP 8.0 (or above) will be the minimum supported version
*
* @return static
*/
public static function fromArray(array $params, bool $allowExtraProperties = false)
public static function fromArray(array $params, bool $allowExtraProperties = false): static
{
$instance = new static();
$instance->fillFromArray($params, $allowExtraProperties);
Expand Down
Loading