Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add static as return type of BaseObject fromArray method #45

Merged
merged 1 commit into from
Jul 30, 2023
Merged

feat: add static as return type of BaseObject fromArray method #45

merged 1 commit into from
Jul 30, 2023

Conversation

antonioturdo
Copy link
Collaborator

🚨 Proposed changes

From PHP 8.0 static return type is allowed. Since 8.0 is now the minimum version we can now use it.

⚙️ Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Refactor

@antonioturdo antonioturdo merged commit 228be73 into main Jul 30, 2023
4 checks passed
@antonioturdo antonioturdo deleted the feat/static-return branch July 30, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JellyBellyDev JellyBellyDev JellyBellyDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonioturdo @JellyBellyDev