-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new dispatcher that can move windows in and out of groups, or swap windows #3006
Conversation
ee38dda
to
b306b52
Compare
request my review when ready |
PR is ready for review (I removed the draft status 3 days ago). However, I would not be able to respond until around 6 UTC tomorrow. side notes:
|
didn't know that? I've had a review requested from me a buncha times, iirc.
Just because I reply within minutes if awake doesnt mean you have to. No pressure, lol |
¿¿, I think its on the docs.
|
…, or swap windows. This is a work in progress.
…oup in moveoutofgroup
All right, I'm going to ask for another round of review. I hope this is not very discourteous. |
fix the conflict and then request my review :) |
Conflict with #3229 resolved, ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just needs a wiki mr.
In addition: - Implement directional moveWindowOutOfGroup for `movewindoworgroup` when using dwindle layout. (augmentation of hyprwm#3006) - Replace `DWindleLayout::OneTimeFocus` with `IHyprLayout::eDirection`. - Slight formatting change (clang-format).
* feat(layout): add direction parameter to onWindowCreated and friends In addition: - Implement directional moveWindowOutOfGroup for `movewindoworgroup` when using dwindle layout. (augmentation of #3006) - Replace `DWindleLayout::OneTimeFocus` with `IHyprLayout::eDirection`. - Slight formatting change (clang-format). * fix: nullptr dereference in dwindle window creation * refactor: generalized eDirection * refactor: eliminate DIRECTION_NONE * Update IHyprLayout.hpp
…m#3269) * feat(layout): add direction parameter to onWindowCreated and friends In addition: - Implement directional moveWindowOutOfGroup for `movewindoworgroup` when using dwindle layout. (augmentation of hyprwm#3006) - Replace `DWindleLayout::OneTimeFocus` with `IHyprLayout::eDirection`. - Slight formatting change (clang-format). * fix: nullptr dereference in dwindle window creation * refactor: generalized eDirection * refactor: eliminate DIRECTION_NONE * Update IHyprLayout.hpp
[Breaking change] Add a new dispatcher
movewindoworgroup
that implements the behaviour of moveintowindow, swapwindow and moveoutofwindow.Partial implementation of #2851
Beehaviour
moveIntoGroup
moveOutOfGroup
until directional control is implementedmoveWindowTo
/moveIntoGroup
moveIntoGroup
moveWindowTo
/moveIntoGroup
moveOutOfGroup
moveWindowTo
/moveOutOfGroup
moveWindowTo
moveOutOfGroup
moveOutOfGroup
legend:
group
: The window is in a group.group locked
:m_sGroupData.pNextWindow
is true.window
: The window is not in a group.null
: No window in directionNOTE:
binds:ignore_group_lock
TODO:
focusWindow
configurable.setignoregrouplock
dispatcherOther Changes
moveIntoGroup
andmoveOutOfGroup
to standalone functions.g_pCompositor->focusWindow
inmoveWindowOutOfGroup
.moveintogroup
locking check.moveintogroup_lock_check
,moveintogroup
will checkbinds:ignore_group_lock
insteadmisc:group_focus_removed_window