layout: add direction parameter to onWindowCreated and friends

[memchr]

Abstract

Add a direction parameter with a default value to the onWindowCreated and onWindowCreatedTiling virtual methods of IHyprLayout. This parameter allows potential control over the direction of window creation.

Currently only DWindleLayout has an existing implementation of such control.
Does not affect master layout.

Other Changes

• Implement directional moveWindowOutOfGroup for movewindoworgroup. (augmentation of feat: add a new dispatcher that can move windows in and out of groups, or swap windows #3006)
• Replace DWindleLayout::OneTimeFocus with IHyprLayout::eDirection.
• Slight formatting change (clang-format).
• Fix nullptr dereference in Dwindle window creation at

  Hyprland/src/layout/DwindleLayout.cpp

  Lines 298 to 308 in ed51fe7

  	if ((!OPENINGON || OPENINGON->pWindow == pWindow) && getNodesOnWorkspace(PNODE->workspaceID) > 1) {
  	for (auto& node : m_lDwindleNodesData) {
  	if (node.workspaceID == PNODE->workspaceID && node.pWindow != pWindow) {
  	OPENINGON = &node;
  	break;
  	}
  	}
  	}
  	// if it's the first, it's easy. Make it fullscreen.
  	if (!OPENINGON || OPENINGON->pWindow == pWindow) {

The probability of this nullptr dereference being triggered is low, perhaps elucidating its belated detection.

[vaxerski]

I fail to see the use?

[memchr]

• Supplement to fix a limitation in feat: add a new dispatcher that can move windows in and out of groups, or swap windows #3006, (moveWindowOutOfGroup)
• Possible use in layout restoration

[vaxerski]

top g

[vaxerski]

doesnt this require a wiki mr too? for movewindowoutofgroup

[memchr]

Probably not, I find the old behaviour unexpected (e.g. movewindoworgroup left on groups sometimes creates a new window on the right or above).
The new beehaviour should be more intuitive.

[vaxerski]

okay