-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature build traceroute #836
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Just a few things left to do.
@@ -1,6 +1,6 @@ | |||
# License: LGPL-3.0-or-later | |||
name: Ruby test and build | |||
on: | |||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to remove the reformatting here. There's nothing really wrong with the end result but it clutters the PR
ruby-version: ${{ matrix.ruby }} | ||
bundler-cache: true | ||
- name: Traceroute run | ||
run: rake traceroute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the error provided by the workflow action, I think this should be bundle exec rake traceroute
.
Add get-params spec
please don't merge this pull request!!!
This pull request have the objective to test the job traceroute in the build process in the ruby workflow