Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature build traceroute #836

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

marcelog5
Copy link
Contributor

please don't merge this pull request!!!

This pull request have the objective to test the job traceroute in the build process in the ruby workflow

Copy link
Member

@wwahammy wwahammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Just a few things left to do.

@@ -1,6 +1,6 @@
# License: LGPL-3.0-or-later
name: Ruby test and build
on:
on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to remove the reformatting here. There's nothing really wrong with the end result but it clutters the PR

ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Traceroute run
run: rake traceroute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the error provided by the workflow action, I think this should be bundle exec rake traceroute.

@wwahammy wwahammy marked this pull request as draft November 19, 2021 17:08
wwahammy added a commit to wwahammy/houdini that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants