[FEATURE] Run traceroute as part of the build process

[wwahammy]

Is your feature request related to a problem? Please describe.
It's easy to overlook controller actions which have been incorrectly listed as public or who haven't had a proper route set up.

Describe the solution you'd like
traceroute allows us to run a command and have the build fail if the system if an incorrect set of routes are included. We actually have it in our Gemfile but we haven't gone through the effort of adding it to the build and making sure the exact set of exclusions are listed.

[marcelog5]

Hi @wwahammy I will try to make thiss issue. Because of that I have some questions:
Adding to the build represent adding in the bin/setup?
What is the exact set of exclusion that you mentioned?

[marcelog5]

Hi @wwahammy I have runned the traceroute and the result was that:

How can I identify what is the exact set of exclusions that you mentioned?

[wwahammy]

Hey there @marcelog5! The build process goes into https://github.com/houdiniproject/houdini/blob/main/.github/workflows/ruby.yml

You need to create a new job in this file. The easiest way to do so would be to copy the rubocop one, rename it to traceroute and then change the step in the job to refer to traceroute.

As for exclusions, make sure to exclude all of the ones that start with devise. I think that's all of them for now. I'll have to investigate the rest of them.

[marcelog5]

Hi @wwahammy thanks for the help, have a way to I test if the build is working, because I see in the build that it only run when make a Pull Request?

I make a PR and comment to not merge?

[wwahammy]

Hi @wwahammy thanks for the help, have a way to I test if the build is working, because I see in the build that it only run when make a Pull Request?

I make a PR and comment to not merge?

Send it as a draft PR and comment that it shouldn't be merged.

[marcelog5]

Hi @wwahammy when you mean the set of exclusion, you mean delete that endpoints. For example you say to exclude devise, I will need to remove this gem? Or I'am doing wrong.

[wwahammy]

Hey @marcelog5, I meant excluding those from the traceroute check so they would not, in and of themselves, make the traceroute test fail. Information on how to ignore routes is available at the traceroute webpage

[marcelog5]

Hey @wwahammy to update you the test pull request is in this link: #836. I have put only the devise in the .traceroute.yaml to be ignored.