Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: capitalize Uhyve #709

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Jun 13, 2024

Based on #689

Fixes #458
Closes #689

Based on hermit-os#689

Fixes hermit-os#458

Co-authored-by: charlottestinson <[email protected]>
Co-authored-by: Jonathan Munoz <[email protected]>
@n0toose
Copy link
Member Author

n0toose commented Jun 13, 2024

Succeeds #689.


CC: @charlottestinson @MrMunoz

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.06%. Comparing base (9ba3c9d) to head (c6c5375).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   68.06%   68.06%           
=======================================
  Files          20       20           
  Lines        2311     2311           
=======================================
  Hits         1573     1573           
  Misses        738      738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkroening mkroening self-assigned this Jun 13, 2024
@mkroening mkroening self-requested a review June 13, 2024 17:40
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@jounathaen jounathaen added this pull request to the merge queue Jun 14, 2024
@mkroening mkroening removed this pull request from the merge queue due to a manual request Jun 14, 2024
@mkroening mkroening added this pull request to the merge queue Jun 14, 2024
Merged via the queue into hermit-os:main with commit 3e869b0 Jun 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider capitalizing Uhyve throughout the docs
2 participants