Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: capitalize Uhyve #689

Closed
wants to merge 3 commits into from
Closed

Conversation

charlottestinson
Copy link
Contributor

@charlottestinson charlottestinson commented May 6, 2024

Updated so that uhyve is capitalized.

Closes #458

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.11%. Comparing base (3e6edc2) to head (a84e26e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files          20       20           
  Lines        2308     2308           
=======================================
  Hits         1572     1572           
  Misses        736      736           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! :)

Please remove the .DS_Store file and any changes to Cargo.toml and Cargo.lock. Please also squash your changes into one commit. If you need help, feel free to reach out.

By the way: If you want to credit multiple as authors of a commit, add the following line to the end of the commit message:

Co-authored-by: NAME <[email protected]>

See Creating a commit with multiple authors - GitHub Docs.

@mkroening mkroening self-assigned this May 7, 2024
@mkroening mkroening changed the title Capitalized Uhyve docs: capitalize Uhyve May 18, 2024
@mkroening
Copy link
Member

@charlottestinson, @MrMunoz, are you planning to continue pursuing this PR? :)

@n0toose
Copy link
Member

n0toose commented Jun 12, 2024

If there's no disagreement from the original authors, I'll rebase the changes onto a new PR (while preserving credit) in the coming days real quick so as to push this over the finish line.

n0toose added a commit to n0toose/uhyve that referenced this pull request Jun 13, 2024
Based on hermit-os#689

Fixes hermit-os#458

Co-authored-by: charlottestinson <[email protected]>
Co-authored-by: Jonathan Munoz <[email protected]>
@n0toose n0toose mentioned this pull request Jun 13, 2024
@jounathaen
Copy link
Member

Implemented in #709

@jounathaen jounathaen closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider capitalizing Uhyve throughout the docs
5 participants