-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: capitalize Uhyve #689
Conversation
Capitalized Uhyve throughout docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 20 20
Lines 2308 2308
=======================================
Hits 1572 1572
Misses 736 736 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! :)
Please remove the .DS_Store
file and any changes to Cargo.toml
and Cargo.lock
. Please also squash your changes into one commit. If you need help, feel free to reach out.
By the way: If you want to credit multiple as authors of a commit, add the following line to the end of the commit message:
Co-authored-by: NAME <[email protected]>
@charlottestinson, @MrMunoz, are you planning to continue pursuing this PR? :) |
If there's no disagreement from the original authors, I'll rebase the changes onto a new PR (while preserving credit) in the coming days real quick so as to push this over the finish line. |
Based on hermit-os#689 Fixes hermit-os#458 Co-authored-by: charlottestinson <[email protected]> Co-authored-by: Jonathan Munoz <[email protected]>
Implemented in #709 |
Updated so that uhyve is capitalized.
Closes #458