Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Add queue name to pull_request_rules #5741

Merged
merged 2 commits into from
Sep 3, 2024
Merged

🚚 Add queue name to pull_request_rules #5741

merged 2 commits into from
Sep 3, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Sep 3, 2024

The mergify script is not working properly and we might think it can be related to this:

Oops! In hindsight, I think we shouldn't have removed this part:

queue:
  name: default_queue

That's probably the command to enqueue the PR for actual merging.

Noticing this after noticing that the Weblate PR didn't merge itself.

Original comment made by Rico in: https://github.com/hedyorg/hedy/pull/5738/files#r1742077765

@jpelay
Copy link
Member Author

jpelay commented Sep 3, 2024

Before approving this we might want to wait for #5725 to finish running the tests to see if that one gets merged, if it doesn't then I think we did messed up with the configuration

Copy link
Contributor

mergify bot commented Sep 3, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Sep 3, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@jpelay jpelay merged commit 9017618 into main Sep 3, 2024
11 checks passed
@jpelay jpelay deleted the mergify-2 branch September 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants