-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Change deprecrated Mergify rules #5738
Conversation
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
@@ -16,10 +20,4 @@ pull_request_rules: | |||
actions: | |||
comment: | |||
message: Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to [allow changes to be pushed to your fork](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork)). | |||
queue: | |||
name: default_queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! In hindsight, I think we shouldn't have removed this part:
queue:
name: default_queue
That's probably the command to enqueue the PR for actual merging.
Noticing this after noticing that the Weblate PR didn't merge itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! Made a PR: #5741 !
@rix0rrr pointed out to my attention that Mergify was complaining about some rules we were using incorrectly. The documentation says that they're now part of
queue_rules
.How to test
We'll have to check this run in the following days.