feat: beatutify busTooltip & make lineProfilePage actually work #744
Conversation
…e line pages All the logic existed before - I just moved it into a hook to enable reuse! This hook supports both SingleLineMap Page & LineProfile Page as they need practically the same information
itsoriki
changed the title
|
@NoamGaash I can't figure out why that one job is failing consistently - No real error is printed to the console... |
|
run |
|
@NoamGaash Sorry for the "mess" - can you review this PR now that everything has passed? Btw the @all-contributors friend of ours doesn't seem to care at all about adding me to the contributors list :( |
There was a problem hiding this comment.
That's a great improvement!
few suggestions:
- I'm not sure that we need the expanding button - what is it good for?
- We can consider translating the direction (290 מעלות) to geographic terms (צפון מערב, אזימוט 290)
- when the tooltip is too tall. we can add an inner scrollbar or something similar
wdyt?
| useEffect(() => { | ||
| window.scrollTo(0, 0) | ||
| }, []) |
There was a problem hiding this comment.
I don't know why, but when you first arrive on this page, you are not at the top of it (i.e. you don't see the title for example) (see picture for the view when you first arrive the page)
Is there a better way to do it?
There was a problem hiding this comment.
I'm not sure, we can investigate that later
|
|
Thank you! 👏 @all-contributor please add @itsoriki for code :) |
|
maybe |
|
I've put up a pull request to add @itsoriki! 🎉 |
Resolves #543
Description
BusTooltipaccording to language (also add a collapsible section)screenshots