place a copy of single-line-map (מפה לפי קו) inside the line profile page

[NoamGaash]

Add a widget to the profile page with a "start time" picker, that will show a map of the selected actual ride

[NoamGaash]

see #193 for more ideas

[Haswell-s]

Can you clarify the issue? how do I get to this profile page?

[NoamGaash]

the address https://open-bus-map-search.hasadna.org.il/profile/124314 should lead to the profile page. However, seems the entire page should be fixed first

[amabelleS]

@NoamGaash This is a sub-task of #316.
We also discussed developing a hook to retrieve the last stops of that line.
In PR #434 itai is adding stops as a param to the map component in the single line map page. Then we can use the same map component to display the stops on a map on the profile page
Is there an open issue for the hook part?

[NoamGaash]

@amabelleS it's not a sub-task. I want two maps - one for the last planned ride, other for the last executed ride
the hook is implementation detail, not a requirement specification. we don't need issue for that

[amabelleS]

@amabelleS it's not a sub-task. I want two maps - one for the last planned ride, other for the last executed ride the hook is implementation detail, not a requirement specification. we don't need issue for that

Thank you for explaining this to me:) I'm still trying to understand - this issue is about adding a copy of the single line map in the profile page = for the last executed ride of that line.
#316 is adding a map (the same map component, or similar) to the profile page, but for the planned last ride.
Is it the same ride, but the difference is between planned/supposed stops and a line between them, and actual/executed ride?

Maybe we need a Figma for the profile page, it will be easier for the developers, and for sure will look better.

[NoamGaash]

this issue is for adding the entire page, including the date-time pickers, excluding the bus-lines picker. fill free to create a figma / zeplin / xd if you think it will help

[itsoriki]

@NoamGaash I am a bit confused - I merged my #744 but going to https://open-bus-map-search.hasadna.org.il/profile/4184905 still shows the old style. I saw that the pipeline was successful. What am I missing here? Aren't the changes automatically deployed?

[itsoriki]

Should be resolved by #744 but I am not closing yet as I didn't see the new design in production somehow

[NoamGaash]

sometimes the production takes some time to update

[itsoriki]

This issue has been resolved by #744

[NoamGaash]

Thank you @itsoriki !
@all-contributors please add @itsoriki for code
🏅

[allcontributors]

@NoamGaash

@itsoriki already contributed before to code