Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use proper path for wave fetch. #2177 #2183

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: Use proper path for wave fetch. #2177 #2183

merged 1 commit into from
Nov 3, 2023

Commits on Nov 3, 2023

  1. fix: wave fetch failing because of incorrect url generation. 

    URL  should begenerated for fetching should be  of the format: `wave-{version}-{operating_system}-{arch}`

But the fetch url being generated was using `platform` instead of the `operating_sysyem`.

Since this variable is set on the build time. Changed the `hatch_build.py` file. This will also change the `metadata.py` file that gets generated.

Refs: h2oai#2177 (closes this issue)#
    Yashasvi Mantha committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8bdd56d View commit details
    Browse the repository at this point in the history