fix: Use proper path for wave fetch. #2177 #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL should begenerated for fetching should be of the format: `wave-{version}-{operating_system}-{arch}`
But the fetch url being generated was using `platform` instead of the `operating_sysyem`.
Since this variable is set on the build time. Changed the `hatch_build.py` file. This will also change the `metadata.py` file that gets generated.
Refs: h2oai#2177 (closes this issue)#
YashasviMantha
changed the title
mturoci
changed the title
mturoci
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
LGTM, thanks @YashasviMantha! Kudos for being able to navigate the whole build system almost completely on your own :)
marek-mihok
pushed a commit
that referenced
this pull request
Jan 15, 2024
mturoci
pushed a commit
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL generated for fetching should be of the format:
wave-{version}-{operating_system}-{arch}But the fetch url being generated was using
platforminstead of theoperating_system.Since this variable is set on the build time. Changed the
hatch_build.pyfile. This will also change themetadata.pyfile that gets generated.Closes #2177
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.