Ensure messageSource type is StaticMessageSource for tests

[jamesfredley]

StaticMessageSource incudes addMessage() methods, required by tests

after removing micronaut, the messageSource type was PluginAwareResourceBundleMessageSource instead of StaticMessageSource when the tests execute

org.grails.plugins.i18n.I18nGrailsPlugin doWithSpring() sets messageSource to type PluginAwareResourceBundleMessageSource

org.grails.testing.GrailsApplicationBuilder.build() sets messageSource to type StaticMessageSource in doWithSpringClosure{} which calls registerBeans()

On grails/grails-core#13702

This fixes 22 tests that require StaticMessageSource

It also fixes 6 tests in DataBindingConfigurationSpec with ValueConverters using @Order

[codeconsole]

Why wasn't it an issue before with Micronaut?

https://github.com/grails/grails-core/blob/2932a6321bf8987b82e33b64bbd702fa8883b1aa/grails-plugin-i18n/src/main/groovy/org/grails/plugins/i18n/I18nGrailsPlugin.groovy#L48-L68

[jamesfredley]

So far my guess is order of execution with org.grails.plugins.i18n.I18nGrailsPlugin doWithSpring() running earlier before Micronaut removal and later after Micronaut removal.

I experimented with setting it to StaticMessageSource in few locations and if it is set too early it gets overridden by org.grails.plugins.i18n.I18nGrailsPlugin doWithSpring() setting it to type PluginAwareResourceBundleMessageSource. The location in this PR is later in the process and after org.grails.plugins.i18n.I18nGrailsPlugin doWithSpring() runs.

[codeconsole]

@jamesfredley perhaps the real issue is that the i18n plugin should not be loaded?

https://github.com/grails/grails-core/blob/2932a6321bf8987b82e33b64bbd702fa8883b1aa/grails-core/src/main/groovy/grails/plugins/DefaultGrailsPluginManager.java#L326

[codeconsole]

Disabling the i18n plugin results in no messageSource being registered.

@jamesfredley I think the real issue here is the TestRuntimeGrailsApplicationPostProcessor (grailsApplicationPostProcessor) never executes and registers the StaticMessageSource

grails-testing-support/grails-testing-support/src/main/groovy/org/grails/testing/GrailsApplicationBuilder.groovy

Lines 191 to 222 in 36c53d2

	protected void registerGrailsAppPostProcessorBean(ConfigurableBeanFactory beanFactory) {
	GrailsApplication grailsApp
	Closure doWithSpringClosure = {
	registerBeans(grailsApp)
	executeDoWithSpringCallback(grailsApp)
	}
	Closure customizeGrailsApplicationClosure = { GrailsApplication grailsApplication ->
	grailsApp = grailsApplication
	if (doWithConfig) {
	doWithConfig.call(grailsApplication.config)
	// reset flatConfig
	grailsApplication.configChanged()
	}
	Holders.config = grailsApplication.config
	}
	def constructorArgumentValues = new ConstructorArgumentValues()
	constructorArgumentValues.addIndexedArgumentValue(0, doWithSpringClosure)
	constructorArgumentValues.addIndexedArgumentValue(1, includePlugins ?: DEFAULT_INCLUDED_PLUGINS)
	def values = new MutablePropertyValues()
	values.add('localOverride', localOverride)
	values.add('loadExternalBeans', loadExternalBeans)
	values.add('customizeGrailsApplicationClosure', customizeGrailsApplicationClosure)
	def beanDef = new RootBeanDefinition(TestRuntimeGrailsApplicationPostProcessor, constructorArgumentValues, values)
	beanDef.setRole(BeanDefinition.ROLE_INFRASTRUCTURE)
	(beanFactory as BeanDefinitionRegistry).registerBeanDefinition('grailsApplicationPostProcessor', beanDef)
	}

[jamesfredley]

@codeconsole You are correct that org.grails.testing.GrailsApplicationBuilder.registerGrailsAppPostProcessorBean() runs but the constructor on TestRuntimeGrailsApplicationPostProcessor is not being called later.

[codeconsole]

#435