Skip 7.0.x failing tests #13702
Merged
Skip 7.0.x failing tests #13702
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run with commit prior to Micronaut removal. The total includes some tests which get rerun.
|
|
I started down that route, but adding that many skips seemed a bit extreme. Especially considering something like this takes out most of them |
…pport#435 These tests require StaticMessageSource instead of PluginAwareResourceBundleMessageSource
matrei
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
@PendingFeatureannotation to run but skip failing tests, adds@Ignorewhen test cannot be run at all without stopping build this adds 3 skipped tests to the ~15 that existed previously https://github.com/grails/grails-core/pull/13702/filesre-enable tests in gradle.yml for snapshots 4857502
Before grails/grails-testing-support#435
After grails/grails-testing-support#435
