Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit encoding for reading from file. #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FilipJirsak
Copy link

@FilipJirsak FilipJirsak commented Apr 10, 2021

open() without encoding uses platform default encoding. On Windows it can be encoding that has some bytes undefined - for example, in Windows-1250 encoding there doesn't exist char with code 0x88.

open() without encoding uses platform default encoding. On WIndows it can be encoding which has some bytes undefined - for example Windows-1250 don't know 0x88.
@graalvmbot
Copy link
Collaborator

Hello Filip Jirsák, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address filip -(at)- jirsak -(dot)- org. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@graalvmbot
Copy link
Collaborator

Filip Jirsák has signed the Oracle Contributor Agreement (based on email address filip -(at)- jirsak -(dot)- org) so can contribute to this repository.

@@ -130,7 +130,7 @@ def read_core_prefs_file(self):
class FileInfo:
def __init__(self, path):
self.path = path
with open(path) as fp:
with open(path, encoding='utf-8') as fp:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work on python2:

  File "/b/b/e/path with a space/mx_ide_eclipse.py", line 133, in __init__
    with open(path, encoding='utf-8') as fp:
TypeError: 'encoding' is an invalid keyword argument for this function

We are working to make mx require python 3.6 but are not quite there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants