Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit encoding for reading from file. #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use explicit encoding for reading from file. #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mx_ide_eclipse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def read_core_prefs_file(self):
class FileInfo:
def __init__(self, path):
self.path = path
with open(path) as fp:
with open(path, encoding='utf-8') as fp:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work on python2:

  File "/b/b/e/path with a space/mx_ide_eclipse.py", line 133, in __init__
    with open(path, encoding='utf-8') as fp:
TypeError: 'encoding' is an invalid keyword argument for this function

We are working to make mx require python 3.6 but are not quite there yet.

self.content = fp.read()
self.times = (os.path.getatime(path), mx.getmtime(path))

Expand Down