fix: handle zeros in paginated meta info correctly #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusheine
changed the title
mariusheine
changed the title
anbraten
previously approved these changes
Dec 12, 2023
Co-authored-by: Anbraten <[email protected]>
anbraten
changed the title
anbraten
approved these changes
Dec 12, 2023
anbraten
deleted the
81-zeros-in-paginated-meta-info-is-evaluated-incorrectly
branch
|
🎉 This PR is included in version 3.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #81
We don't check against
!== undefinedanymore but we now check for the type of the relevant pagination meta fieldstotal,limitandskipsince the check!== undefinedwas transpiled into!== void 0. This caused responses where any of these 3 fields were0to be evaluated as no paginated response and therefor led to wrong handling