Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeros in paginated meta info is evaluated incorrectly #81

Closed
mariusheine opened this issue Dec 11, 2023 · 3 comments · Fixed by #82
Closed

zeros in paginated meta info is evaluated incorrectly #81

mariusheine opened this issue Dec 11, 2023 · 3 comments · Fixed by #82
Labels
released

Comments

@mariusheine
Copy link
Member

E.g. if skip is set to 0 the response is not evaluated correctly as paginated data.
@mariusheine
Copy link
Member Author

It seams to be the case when bundling for the browser where the condition skip !== undefined is transformed to skip !== void 0 ...

Why does this happens...

@mariusheine
Copy link
Member Author

It definitely happens through the build process of this library. When running pnpm build and checking dist/index.js we will find in the isPaginated function the falsy code skip !== void 0

@mariusheine mariusheine mentioned this issue Dec 11, 2023
Merged
@mariusheine mariusheine linked a pull request Dec 11, 2023 that will close this issue
fix: handle zeros in paginated meta info correctly #82
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle zeros in paginated meta info correctly geprog/use-feathers
1 participant
@mariusheine