Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #81 Updated the following behaviors: #82

Merged

Conversation

FlorentP42
Copy link
Collaborator

  • Updated south_event generation behavior when terminating an incomplete GI.
  • Ensured quality update for missing TS was always sent at the end of a GI.
  • Added logs for easier debugging of GI failure cases and anticipation ratio delays.
  • Updated unit test to reflect the new expected behavior.
    Closes An incomplete CG should produce a "finished" gi_status #81

* Updated south_event generation behavior when terminating an incomplete GI.
* Ensured quality update for missing TS was always sent at the end of a GI.
* Added logs for easier debugging of GI failure cases and anticipation ratio delays.
* Updated unit test to reflect the new expected behavior.

Signed-off-by: Florent Peyrusse <[email protected]>
Florent Peyrusse added 2 commits January 26, 2024 14:47
Signed-off-by: Florent Peyrusse <[email protected]>
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

61.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@FlorentP42 FlorentP42 linked an issue Jan 29, 2024 that may be closed by this pull request
@YmaIneo YmaIneo merged commit 7e51579 into develop Jan 29, 2024
3 of 4 checks passed
@FlorentP42 FlorentP42 deleted the 81-an-incomplete-cg-should-produce-a-finished-gi_status branch January 29, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An incomplete CG should produce a "finished" gi_status
2 participants