Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An incomplete CG should produce a "finished" gi_status #81

Closed
FlorentP42 opened this issue Jan 24, 2024 · 0 comments · Fixed by #82
Closed

An incomplete CG should produce a "finished" gi_status #81

FlorentP42 opened this issue Jan 24, 2024 · 0 comments · Fixed by #82
Assignees
Labels
enhancement New feature or request

Comments

@FlorentP42
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently when a CG is completed, if some of the TS in the CG are missing, the south_event will be generated with gi_status=failed.
In order to match the behavior of the IEC104 south plugin, gi_status=finished should be sent in that case instead.

Describe the solution you'd like
When a CG completes emit a south_event with gi_status=finished regardless of the number of TS received during the CG (missing or extra).
Add a log indicating if some expected TS were missing or some unexpected TS were received.

Describe alternatives you've considered
N/A

Additional context
N/A

@FlorentP42 FlorentP42 self-assigned this Jan 24, 2024
@FlorentP42 FlorentP42 added the enhancement New feature or request label Jan 24, 2024
FlorentP42 pushed a commit that referenced this issue Jan 26, 2024
* Updated south_event generation behavior when terminating an incomplete GI.
* Ensured quality update for missing TS was always sent at the end of a GI.
* Added logs for easier debugging of GI failure cases and anticipation ratio delays.
* Updated unit test to reflect the new expected behavior.

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Jan 26, 2024
Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Jan 26, 2024
@FlorentP42 FlorentP42 linked a pull request Jan 29, 2024 that will close this issue
YmaIneo added a commit that referenced this issue Jan 29, 2024
…roduce-a-finished-gi_status

refs #81 Updated the following behaviors:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant