Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60 never stop attempting to connect #61

Merged
merged 13 commits into from
Aug 29, 2023

Conversation

FlorentP42
Copy link
Collaborator

Closes #60

Florent Peyrusse added 4 commits August 25, 2023 09:57
…running unit tests.

Signed-off-by: Florent Peyrusse <[email protected]>
…ect as long as the plugin is running. Refactored basic_hnz_server to handle manual reconnection.

Signed-off-by: Florent Peyrusse <[email protected]>
- Fixed plugin attempting to reopen connection while it is shutting down.
- Switch path now always happen (even if other path is not connected).
- Also attempt to switch path when connection is lost.
- Connection status is updated when switching path.
- Fixed repeated state change hen receiving multiple UA after connection is fully established.
- Fixed test server never timing out in certain situations, leading to never ending tests.

Signed-off-by: Florent Peyrusse <[email protected]>
@FlorentP42 FlorentP42 force-pushed the 60-never-stop-attempting-to-connect branch from 0cdab8f to a029ade Compare August 25, 2023 08:00
Florent Peyrusse added 2 commits August 25, 2023 13:19
…leted connection loss test to validate that messages can be exchanged correctly on the new connection.

Signed-off-by: Florent Peyrusse <[email protected]>
…d twice on the same path due to a path swap occuring during the sleep in HNZ::start, leading to infinite loop. Added mutex to prevent race condition on the active and passive path in HNZConnection.

Signed-off-by: Florent Peyrusse <[email protected]>
@FlorentP42 FlorentP42 force-pushed the 60-never-stop-attempting-to-connect branch from ae50894 to aaceb3e Compare August 25, 2023 14:47
Florent Peyrusse added 3 commits August 25, 2023 17:28
…to initialize the TCP connection (without this a path swap may happen during connection init, resulting in failure for some tests relying on precise a path to be active).

Signed-off-by: Florent Peyrusse <[email protected]>
Signed-off-by: Florent Peyrusse <[email protected]>
@FlorentP42 FlorentP42 force-pushed the 60-never-stop-attempting-to-connect branch from b93554f to 58b660c Compare August 28, 2023 09:52
Florent Peyrusse added 4 commits August 28, 2023 15:24
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

47.1% 47.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@YmaIneo YmaIneo merged commit 0d5f25b into develop Aug 29, 2023
4 of 5 checks passed
@FlorentP42 FlorentP42 deleted the 60-never-stop-attempting-to-connect branch August 29, 2023 09:09
@FlorentP42 FlorentP42 linked an issue Aug 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Never stop attempting to connect
2 participants