Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never stop attempting to connect #60

Closed
FlorentP42 opened this issue Jul 11, 2023 · 0 comments · Fixed by #61
Closed

Never stop attempting to connect #60

FlorentP42 opened this issue Jul 11, 2023 · 0 comments · Fixed by #61
Assignees
@FlorentP42
Labels
enhancement New feature or request

Comments

@FlorentP42
Copy link
Collaborator

FlorentP42 commented Jul 11, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, if the connexion attempt with the HNZ device fails 5 times in a row, the HNZ south plugin stops attempting to connect on this path, forever (until the whole plugin is reastarted).
A similar case happen when the inactivity timeout triggers during the SARM/UA phase: the connection thread remain stuck in an infinite loop not sending any message any more.

Describe the solution you'd like
The plugin should never stop attempting to connect on both path, until the plugin is shutting down.
When the inactivity timeout is reached during the SARM/UA phase, the server should restart the TCP connection.

Describe alternatives you've considered
N/A

Additional context
N/A
@FlorentP42 FlorentP42 self-assigned this Jul 11, 2023
@FlorentP42 FlorentP42 added the enhancement New feature or request label Jul 11, 2023
FlorentP42 pushed a commit that referenced this issue Jul 13, 2023
refs #60 Added logging utility function to be able to see logs while …
ce42f26 
…reunning unit tests.
FlorentP42 pushed a commit that referenced this issue Jul 13, 2023
refs #60 Added logging utility function to be able to see logs while …
85e486c 
…running unit tests.
FlorentP42 pushed a commit that referenced this issue Jul 13, 2023
refs #60 Updated loss of connection logic to always be able to reconn…
318b475 
…ect as long as the plugin is running. Refactored basic_hnz_server to handle manual reconnection.
@FlorentP42 FlorentP42 mentioned this issue Jul 13, 2023
Closed
FlorentP42 pushed a commit that referenced this issue Jul 13, 2023
refs #60 Improved logging from basic_hnz_server.
723bd17
FlorentP42 pushed a commit that referenced this issue Aug 24, 2023
refs #60 Fixed plugin attempting to reopen connection while it is shu…
0cdab8f 
…tting down. Switch path now always happen (even if other path is not connected). Also attempt to switch path when connection is lost. Connection status is updated when switching path. Fixed repeated state change hen receiving multiple UA after connection is fully established. Fixed test server never timing out in certain situations, leading to never ending tests.
@FlorentP42 FlorentP42 mentioned this issue Aug 25, 2023
Merged
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Added logging utility function to be able to see logs while …
b190b6d 
…running unit tests.

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Updated loss of connection logic to always be able to reconn…
efc85b9 
…ect as long as the plugin is running. Refactored basic_hnz_server to handle manual reconnection.

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Improved logging from basic_hnz_server.
06d80dc 
Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Fixed the following issues:
a029ade 
- Fixed plugin attempting to reopen connection while it is shutting down.
- Switch path now always happen (even if other path is not connected).
- Also attempt to switch path when connection is lost.
- Connection status is updated when switching path.
- Fixed repeated state change hen receiving multiple UA after connection is fully established.
- Fixed test server never timing out in certain situations, leading to never ending tests.

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Fixed many potential race conditions in BasicHNZServer. Comp…
e8720aa 
…leted connection loss test to validate that messages can be exchanged correctly on the new connection.

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Fixed an issue where the HNZ::receive thread could be starte…
ae50894 
…d twice on the same path, leading to infinite loop. Added mutex to prevent race condition on the active and passive path in HNZConnection.

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Fixed an issue where the HNZ::receive thread could be starte…
aaceb3e 
…d twice on the same path due to a path swap occuring during the sleep in HNZ::start, leading to infinite loop. Added mutex to prevent race condition on the active and passive path in HNZConnection.

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 25, 2023
refs #60 Added a delay after HNZ server start to give it enough time …
f7066af 
…to initialize the TCP connection (without this a path swap may happen during connection init, resulting in failure for some tests relying on precise a path to be active).

Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 28, 2023
refs #60 Sonarqube code quality fixes.
b93554f
FlorentP42 pushed a commit that referenced this issue Aug 28, 2023
refs #60 Sonarqube code quality fixes.
2378aa4 
Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 28, 2023
refs #60 Sonarqube code quality fixes part 2.
58b660c 
Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 28, 2023
refs #60 Sonarqube code quality fixes part 3.
5499b62 
Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 28, 2023
refs #60 Sonarqube code quality fixes part 4.
ba69ed8 
Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 28, 2023
refs #60 Sonarqube code quality fixes part 5.
ec9eba5 
Signed-off-by: Florent Peyrusse <[email protected]>
FlorentP42 pushed a commit that referenced this issue Aug 29, 2023
refs #60 Increased wait time for CG timeout in test.
4f3e6fb 
Signed-off-by: Florent Peyrusse <[email protected]>
@FlorentP42 FlorentP42 linked a pull request Aug 29, 2023 that will close this issue
60 never stop attempting to connect #61
Merged
@FlorentP42 FlorentP42 mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorentP42 FlorentP42

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@FlorentP42