Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread pool #67

Merged
merged 10 commits into from
Jun 1, 2023
Merged

Thread pool #67

merged 10 commits into from
Jun 1, 2023

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented May 11, 2023 •
edited
Loading

Ported from opencmw including porting of tests from catch2 to ut
Renamed to fit into the project conventions and enabled emscripten
compatibility.

TODO:

  • emscripten support

@wirew0rm wirew0rm self-assigned this May 17, 2023
@wirew0rm wirew0rm force-pushed the threadPool branch 2 times, most recently from 48594cf to 2930e2f Compare May 26, 2023 12:29
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:29 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 12:30 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 14:57 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage May 26, 2023 14:57 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 07:55 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 07:55 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 07:55 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 07:55 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage June 1, 2023 08:05 — with GitHub Actions Inactive
wirew0rm added a commit to fair-acc/opencmw-cpp that referenced this pull request Jun 1, 2023
@wirew0rm
ThreadPool: backport changes from graph-prototype
2d6d787 
Backport of changes from graph prototype. See original issue:
fair-acc/gnuradio4#67

Some noteworthy changes:
- emscripten compatibility: std::jthread -> std::thread, ranges usages
- fix race condition on thread shutdown
- fix #243 (starting and stopping threads in ThreadPool)
@wirew0rm wirew0rm mentioned this pull request Jun 1, 2023
Merged
@wirew0rm wirew0rm merged commit 5619855 into main Jun 1, 2023
@wirew0rm wirew0rm deleted the threadPool branch June 1, 2023 08:40
wirew0rm added a commit to fair-acc/opencmw-cpp that referenced this pull request Jun 1, 2023
@wirew0rm
ThreadPool: backport changes from graph-prototype
c957c48 
Backport of changes from graph prototype. See original issue:
fair-acc/gnuradio4#67

Some noteworthy changes:
- emscripten compatibility: std::jthread -> std::thread, ranges usages
- fix race condition on thread shutdown
- fix #243 (starting and stopping threads in ThreadPool)
wirew0rm added a commit to fair-acc/opencmw-cpp that referenced this pull request Jun 1, 2023
@wirew0rm
ThreadPool: backport changes from graph-prototype
b51498b 
Backport of changes from graph prototype. See original issue:
fair-acc/gnuradio4#67

Some noteworthy changes:
- emscripten compatibility: std::jthread -> std::thread, ranges usages
- fix race condition on thread shutdown
- fix #243 (starting and stopping threads in ThreadPool)
@RalphSteinhagen RalphSteinhagen linked an issue Jul 15, 2023 that may be closed by this pull request
[0pt] Add cancellation support to ThreadPool fair-acc/opencmw-cpp#244
Closed
@RalphSteinhagen RalphSteinhagen mentioned this pull request Jul 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees

@wirew0rm wirew0rm

Labels
None yet
Projects
Digitizer Reimplementation
Status: ✅ QA-Accepted/Merged (∞)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[0pt] Add cancellation support to ThreadPool
2 participants
@wirew0rm @RalphSteinhagen