-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threadpool improvements #298
Conversation
Backport of changes from graph prototype. See original issue: fair-acc/gnuradio4#67 Some noteworthy changes: - emscripten compatibility: std::jthread -> std::thread, ranges usages - fix race condition on thread shutdown - fix #243 (starting and stopping threads in ThreadPool)
0017672
to
15e7420
Compare
Enables execution of emscripten unittests via ctest and unbreak failing emscripten tests.
15e7420
to
b01de3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linked to fair-acc/gnuradio4#67
Thanks for enabling the WASM test work and following up on the ThreadPool adjustments. Nice!
Try to prevent negative hit counts in multithreaded instrumended code. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68080#c4
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 55.29% 55.70% +0.40%
==========================================
Files 68 65 -3
Lines 7216 7174 -42
Branches 2667 2613 -54
==========================================
+ Hits 3990 3996 +6
- Misses 1526 1527 +1
+ Partials 1700 1651 -49
☔ View full report in Codecov by Sentry. |
Added
https://github.com/fair-acc/opencmw-cpp/actions/runs/5142318355/jobs/9257131141#step:14:1360 Since this is not deterministic, I'm not completely sure that this will fix the issue. According to the documentation it gcc should automatically select |
Backport of changes from graph prototype. See original issue:
fair-acc/gnuradio4#67
Some noteworthy changes:
Also enables execution of emscripten unittests via ctest and unbreak failing emscripten tests.