-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new design and logic for the menu #1590 #1568
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I agree with that, although on the other hand, wouldn't it be better to remove these dependencies that are only adding more load to the website? It might also be worth evaluating if these changes could optimize performance and maintenance in the long run. |
Sorry for the delay in responding, I was on vacation for the last two weeks :-) I'm ambivalent about this. Since @bjohansebas has already done the work, I don't know that there's a good reason NOT to accept this PR--ASSUMING that it doesn't introduce any new bugs or glitches. Since I'm just getting back and catching up after vacay, I haven't had time to look more closely at this to ensure that's the case. @chrisdel101 have you? We certainly appreciate the work you put in @bjohansebas but in the future it would be great to open an issue to discuss BEFORE doing the work for a PR. If you already did this and I just missed it, apologies, as I said I've been out for a couple weeks. I'm not saying that we won't accept a PR without prior discussion in an issue, but that's the preferred approach :-) |
I agree with you @crandmck 100% about per-discussing PRs, especially ones like this that are ethos shifting, whereas maybe small bug fixes could slip by without? This Improvements like this do have a legit place in web development. My thoughts are:
So, since you did all this work already it seems like a waste to throw it out. The main problems are:
SO...
This response got WAY too long and rambling. Did this make sense? |
First PR (Refactor Menu):
Second PR (Remove Unused Functions):
Third PR (Adapt get elements):
Fourth PR (Adapt Functions):
Fifth PR (Remove jQuery Dependency):
Note: While writing the proposal, I realized that more PRs are needed to make the review easier. @chrisdel101, do you agree with the proposal? |
Yes this looks good to me overall. Starting w/ the menu as you said is a good plan. Some things to consider:
Is this okay @crandmck? |
Yes, this is a good approach. Thanks for taking the lead on this @chrisdel101. And, of course, thanks @bjohansebas for all the refactoring effort. To help coordinate and simplify reviews, I would suggest opening an issue with the content of the above comment and then link that to all the PRs. |
99f8766
to
f3c78f3
Compare
@chrisdel101, you can review now. I fixed some bugs I found in Chrome, so everything should work fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't a super reviewer on the header files since those are tricky to review. If there's any typos there hopefully we get them over time.
I left a bunch of comments to fix, and some suggestions too.
Great job with this. The navbar is finally a flex box! And the French nav is the correct way around.
The new menu logic is designed, and the new styles are added to work correctly.
Changes
Preview
desktop
mobile