Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Bar styling - Spacing on Logo and Wrap are broken #1589

Open
chrisdel101 opened this issue Sep 2, 2024 · 2 comments
Open

Nav Bar styling - Spacing on Logo and Wrap are broken #1589

chrisdel101 opened this issue Sep 2, 2024 · 2 comments
Labels

Comments

@chrisdel101
Copy link
Contributor

chrisdel101 commented Sep 2, 2024

The spacing is broken after the last few PRs. This is FF for mac.
Screenshot 2024-09-02 at 3 31 19 PM

It could have been #1561 or #1570 that caused this, but this pattern was not showing up in the previews for either, although merges might have happened after initial reviews.

This might be fixed by #1568 PR part1? @bjohansebas when you are looking at the nav redsign please see if you can fix this :)

(Appears to be English only, so not sure markup got changed somewhere?)

@chrisdel101 chrisdel101 added the bug label Sep 2, 2024
@chrisdel101 chrisdel101 changed the title Nav Bar styling - spacing is off Nav Bar styling - Spacing on Logo and Wrap are broken Sep 2, 2024
@bjohansebas
Copy link
Member

I'll review it, although the issue probably started when the support page was introduced in #1585.

@chrisdel101
Copy link
Contributor Author

Ahh okay. I just thought your #1568 had some improvements for the nav, and it did NOT have this issue when I previewed it, so that could fix it, rather than pushing a PR just to fix it. That's why I mentioned that.

I certainly have not seen this bug in any of the previews I've approved lately, and I was not involved with #1585 so maybe you are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants