Add offline and isarConnected prechecks #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔔 Changes in database folder detected 🔔 |
prasm313
force-pushed
the
add-offline-and-isarconnected-prechecks
branch
from
51fb3b2
to
5d1569f
Compare
22 tasks
Christdej
approved these changes
Jun 17, 2024
prasm313
force-pushed
the
add-offline-and-isarconnected-prechecks
branch
from
5d1569f
to
9955ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close one of the points in #1592.
Prior to this PR:
When robot was offline the user could schedule missions but missions would not appear in mission queue.
When robot had connection issues (isarConnected=false), the user could schedule missions, the missions would appear in queue, but the missions would not run even if isar connection was re-established.
After this PR: