Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependenciesMeta.*.injected: true to test-app #107

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Jan 31, 2023

when using peerDependencies, this is a required setting in order for dependency resolution to behave correctly.

For more information see:

[addonInfo.name.dashed]: {
injected: true,
},
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is never written back to the file, isn't it?

Also, we already have a place to extend the file here, maybe we can handle this in one place?

@simonihmig
Copy link
Collaborator

Would be good to have this indeed! Took me way too much time already figuring out hard to understand issues that seem to relate to this (see embroider-build/embroider#1332)

@NullVoxPopuli
Copy link
Collaborator Author

I opened: pnpm/pnpm#6088

I'm nervous about this change because of the lack of automatic re-syncing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants