Add dependenciesMeta.*.injected: true to test-app

embroider-build · Jan 31, 2023 · 30f8b64 · 30f8b64
1 parent f32a9c4
commit 30f8b64
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -77,6 +77,7 @@ module.exports = {
 
     if (options.pnpm) {
       tasks.push(pnpm.createWorkspacesFile(options.target, addonInfo, testAppInfo));
+      tasks.push(pnpm.handleImperfections(addonInfo, testAppInfo));
     }
 
     if (options.releaseIt) {

diff --git a/src/pnpm.js b/src/pnpm.js
@@ -2,6 +2,7 @@
 
 const fs = require('fs/promises');
 const path = require('path');
+const fse = require('fs-extra');
 
 /**
  * @typedef {import('./types').AddonInfo} AddonInfo
@@ -19,6 +20,32 @@ async function createWorkspacesFile(targetPath, addonInfo, testAppInfo) {
   await fs.writeFile(path.join(targetPath, 'pnpm-workspace.yaml'), content);
 }
 
+/**
+ *
+ * @param {AddonInfo} addonInfo
+ * @param {TestAppInfo} testAppInfo
+ */
+async function handleImperfections(addonInfo, testAppInfo) {
+  /**
+   * https://github.com/pnpm/pnpm/issues/4965#issuecomment-1405264290
+   *
+   * for dependencies in a monorepo, AND when peerDependencies need to be resolved correctly,
+   * the dependencies must use `dependenciesMeta.*.injected: true`,
+   *
+   * more info here:
+   *  https://pnpm.io/package_json#dependenciesmetainjected
+   */
+  let testAppPackageJsonPath = path.join(testAppInfo.location, 'package.json');
+  let testAppPackageJson = await fse.readJSON(testAppPackageJsonPath);
+
+  testAppPackageJson.dependenciesMeta = {
+    [addonInfo.name.dashed]: {
+      injected: true,
+    },
+  };
+}
+
 module.exports = {
   createWorkspacesFile,
+  handleImperfections,
 };