Use meshloader to support multiple file formats loading #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tin Lai <[email protected]>
Vrixyz
commented
Sep 30, 2024
Comment on lines
-17
to
+19
| //! - Mesh file types other than `stl` are not supported yet. Contributions are welcome. You my check the `rapier3d-stl` | ||
| //! - Mesh file types are limited. Contributions are welcome. You may check the `rapier3d-meshloader` |
There was a problem hiding this comment.
I'm not sure about what other types urdf could support 🤔
| /// - `converter`: controls how the shapes are computed from the content. In particular, it lets | ||
| /// you specify if the computed [`SharedShape`] is a triangle mesh, its convex hull, | ||
| /// bounding box, etc. | ||
| // TODO: call a function for each mesh to load ? To be able to have a different mesh converter? |
Comment on lines
+8
to
+10
| //! `stl`: support .stl files | ||
| //! `collada`: support .dae files | ||
| //! `wavefront`: support .obj files |
There was a problem hiding this comment.
I'm not a huge fan of listing features here, it sounds like an easy thing to forget when changing features, I'd be more comfortable with an include of the readme.md here 🤔 ?
Vrixyz
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mesh-loaderis added to a more generic crate.CHANGELOG.mdfor a list of changesrapier/crates/rapier3d-meshloader/CHANGELOG.md
Lines 1 to 13 in fb8a7c7