Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/176 amplitude dif #178

Merged
merged 9 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .zenodo.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@
"orcid": "0000-0003-1001-0707",
"affiliation": "Department of Physics and Astronomy, Aarhus University, DK",
"name": "Tronsgaard, René"
},
{
"orcid": "0000-0003-3287-5250",
"affiliation": "Department of Astronomy and the DiRAC Institute, University of Washington, Seattle, WA, USA",
"name": "Caplar, Neven"
}
],
"license": "MIT",
Expand Down
1 change: 1 addition & 0 deletions news/176.doc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarified in documentation that sigma argument is optional in quasisep kernels.
25 changes: 20 additions & 5 deletions src/tinygp/kernels/quasisep.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,10 @@ class SHO(Quasisep):
Args:
omega: The parameter :math:`\omega`.
quality: The parameter :math:`Q`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""

omega: JAXArray
Expand Down Expand Up @@ -464,7 +467,10 @@ class Exp(Quasisep):

Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""

scale: JAXArray
Expand Down Expand Up @@ -498,7 +504,10 @@ class Matern32(Quasisep):

Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""
scale: JAXArray
sigma: JAXArray = field(default_factory=lambda: jnp.ones(()))
Expand Down Expand Up @@ -540,7 +549,10 @@ class Matern52(Quasisep):

Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""

scale: JAXArray
Expand Down Expand Up @@ -602,7 +614,10 @@ class Cosine(Quasisep):

Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""
scale: JAXArray
sigma: JAXArray = field(default_factory=lambda: jnp.ones(()))
Expand Down