Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/176 amplitude dif #178

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Issue/176 amplitude dif #178

merged 9 commits into from
Aug 23, 2023

Conversation

nevencaplar
Copy link
Contributor

@nevencaplar nevencaplar commented Aug 21, 2023

Closes #176

What did I do?
Updated documentation to note that sigma is optional parameter in quasisep kernels; and noted that there is slight computational improvement when specifying sigma explicitly. Same description has been added for Matern32, Matern52, Cosine, Exp and SHO kernels.

@dfm
Copy link
Owner

dfm commented Aug 22, 2023

Thanks!! It looks like I'll need to do some debugging of the docs, but in the meantime can you add yourself to https://github.com/dfm/tinygp/blob/2bf172d7eddfef24f3e8dbe9cf5ceacbe83dbdba/.zenodo.json

news/176.doc Outdated Show resolved Hide resolved
src/tinygp/kernels/quasisep.py Outdated Show resolved Hide resolved
@dfm dfm mentioned this pull request Aug 23, 2023
@dfm
Copy link
Owner

dfm commented Aug 23, 2023

Thanks!! The docs failure is not your issue, so I'll look at that separately.

@dfm dfm merged commit 1cc9577 into dfm:main Aug 23, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difference in definition between quasisep and stationary kernels; amplitude in one but not another
2 participants