Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix to_subaccount getting deleted and release 0.4.4 #217

Merged
merged 4 commits into from
Mar 21, 2024
Merged

fix: Fix to_subaccount getting deleted and release 0.4.4 #217

merged 4 commits into from
Mar 21, 2024

Conversation

adamspofford-dfinity
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review March 21, 2024 17:11
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner March 21, 2024 17:11
lwshang
lwshang reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@lwshang lwshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test for the fix?

@adamspofford-dfinity adamspofford-dfinity merged commit bad5cd7 into master Mar 21, 2024
32 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/patch-4 branch March 21, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamspofford-dfinity @lwshang