fix: Fix to_subaccount getting deleted and release 0.4.4 (#217)

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [0.4.4] - 2024-03-21
+
+- Fixed `quill sns make-proposal` setting some fields to null.
+
 ## [0.4.3] - 2024-01-29
 
 - Updated dependencies.

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "quill"
-version = "0.4.3"
+version = "0.4.4"
 authors = ["DFINITY Team"]
 edition = "2021"
 rust-version = "1.75.0"

src/commands/sns/make_proposal.rs

@@ -8,7 +8,7 @@ use crate::{
     AnyhowResult,
 };
 use anyhow::Error;
-use candid::{Decode, Encode};
+use candid::{CandidType, Decode, Encode, TypeEnv};
 use candid_parser::parse_idl_args;
 use clap::Parser;
 use ic_sns_governance::pb::v1::{manage_neuron, ManageNeuron, Proposal};
@@ -85,6 +85,6 @@ pub fn exec(
 
 fn parse_proposal_from_candid_string(proposal_candid: String) -> AnyhowResult<Proposal> {
     let args = parse_idl_args(&proposal_candid)?;
-    let args: Vec<u8> = args.to_bytes()?;
+    let args: Vec<u8> = args.to_bytes_with_types(&TypeEnv::default(), &[Proposal::ty()])?;
     Decode!(args.as_slice(), Proposal).map_err(Error::msg)
 }

tests/output/default/sns/make_proposal/with_blob.txt

@@ -0,0 +1,29 @@
+Sending message with
+
+  Call type:   update
+  Sender:      fdsgv-62ihb-nbiqv-xgic5-iefsv-3cscz-tmbzv-63qd5-vh43v-dqfrt-pae
+  Canister id: rrkah-fqaaa-aaaaa-aaaaq-cai
+  Method name: manage_neuron
+  Arguments:   (
+  record {
+    subaccount = blob "\83\a7\d2\b1\2f\65\4f\f5\83\35\e5\a2\51\2c\ca\e0\d7\83\9c\74\4b\18\07\a4\7c\96\f5\b9\f3\96\90\69";
+    command = opt variant {
+      MakeProposal = record {
+        url = "example.com";
+        title = "Transfer ICP from SNS treasury.";
+        action = opt variant {
+          TransferSnsTreasuryFunds = record {
+            from_treasury = 1 : int32;
+            to_principal = opt principal "rrkah-fqaaa-aaaaa-aaaaq-cai";
+            to_subaccount = opt record {
+              subaccount = blob "\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\01";
+            };
+            memo = null;
+            amount_e8s = 1_000_000_000 : nat64;
+          }
+        };
+        summary = "";
+      }
+    };
+  },
+)

tests/output/sns.rs

@@ -110,6 +110,23 @@ fn make_proposal() {
         "sns make-proposal {NEURON_ID} --proposal '{proposal}'"
     ))
     .diff("sns/make_proposal/simple.txt");
+    let proposal_with_blob = r#"
+    ( record {
+        title = "Transfer ICP from SNS treasury.";
+        url = "example.com";
+        summary = "";
+        action = opt variant { TransferSnsTreasuryFunds = record {
+            from_treasury = 1 : int32;
+            to_principal = opt principal "rrkah-fqaaa-aaaaa-aaaaq-cai";
+            to_subaccount = opt record { subaccount = vec {0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;0;1} };
+            memo = null;
+            amount_e8s = 1_000_000_000: nat64
+        } };
+    } )"#;
+    quill_sns_send(&format!(
+        "sns make-proposal {NEURON_ID} --proposal '{proposal_with_blob}'"
+    ))
+    .diff("sns/make_proposal/with_blob.txt");
     let proposal_bin = asset("sns_proposal.bin");
     quill_sns_send(&format!(
         "sns make-proposal {NEURON_ID} --proposal-path '{proposal_bin}'",