Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(MR): run the fancier queue compatibility checks against mainnet #1149

Closed
wants to merge 3 commits into from
Closed

test(MR): run the fancier queue compatibility checks against mainnet #1149

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5fd46b
test(MR): run the fancier queue compatibility checks against mainnet
oggy-dfin Aug 26, 2024
b0a9896
Merge branch 'master' into oggy-fancy-queue-compatibility-mainnet
oggy-dfin Aug 26, 2024
eae4944
Merge branch 'master' into oggy-fancy-queue-compatibility-mainnet
oggy-dfin Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions rs/tests/message_routing/queues_compatibility_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,26 +252,26 @@ fn test(env: TestEnv) {

info!(logger, "Mainnet versions: {:?}", mainnet_versions);

let tests = mainnet_versions
.iter()
.map(|v| {
let tests = mainnet_versions.iter().flat_map(|v| {
[
TestCase::new(
TestType::Bidirectional {
published_binary: "replicated-state-test".to_string(),
mainnet_version: v.clone(),
},
"ic/rs/replicated_state/replicated_state_test_binary/replicated_state_test_binary",
"canister_state::queues::tests::mainnet_compatibility_tests::basic_test",
)
})
.chain([TestCase::new(
TestType::Bidirectional {
published_binary: "replicated-state-test".to_string(),
mainnet_version: "2d220277bda0b29c90c48eac66fd56beeed59c11".to_string(),
},
"ic/rs/replicated_state/replicated_state_test_binary/replicated_state_test_binary",
"canister_state::queues::tests::mainnet_compatibility_tests::input_order_test",
)]);
),
TestCase::new(
TestType::Bidirectional {
published_binary: "replicated-state-test".to_string(),
mainnet_version: v.clone(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged this into my alin/MR-523-response-deduplication branch (#1071) and it fails in the same way it failed before #1105, because mainnet master still doesn't have that last change.

I would wait with this until #1105 is on mainnet master.

Otherwise LGTM, thanks for following up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Let's not postpone your PR for 2 more weeks :)
But it is a maintenance burden that I didn't foresee with these comatibility tests, it takes a long time to get rid of mistakes in test cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, turns out they're not only backward compatibility, but also forward compatibility tests. (o:

In this case because all the tests / test fixtures we wrote so far never bothered with unique CallbackIds. But in the future, it may also be the case that we expect canister queues to have certain properties (e.g. some field populated) before we can safely upgrade them. So not only an annoyance.

},
"ic/rs/replicated_state/replicated_state_test_binary/replicated_state_test_binary",
"canister_state::queues::tests::mainnet_compatibility_tests::input_order_test",
),
]
});

for t in tests {
t.run(&logger);
Expand Down