test(MR): run the fancier queue compatibility checks against mainnet #1149
Conversation
| TestCase::new( | ||
| TestType::Bidirectional { | ||
| published_binary: "replicated-state-test".to_string(), | ||
| mainnet_version: v.clone(), |
There was a problem hiding this comment.
Merged this into my alin/MR-523-response-deduplication branch (#1071) and it fails in the same way it failed before #1105, because mainnet master still doesn't have that last change.
I would wait with this until #1105 is on mainnet master.
Otherwise LGTM, thanks for following up.
There was a problem hiding this comment.
Ah. Let's not postpone your PR for 2 more weeks :)
But it is a maintenance burden that I didn't foresee with these comatibility tests, it takes a long time to get rid of mistakes in test cases.
There was a problem hiding this comment.
Yeah, turns out they're not only backward compatibility, but also forward compatibility tests. (o:
In this case because all the tests / test fixtures we wrote so far never bothered with unique CallbackIds. But in the future, it may also be the case that we expect canister queues to have certain properties (e.g. some field populated) before we can safely upgrade them. So not only an annoyance.
|
Already implemented by Alin at some point |
No description provided.