Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nns governance did #389

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Upgrade nns governance did #389

merged 5 commits into from
Aug 2, 2023

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Update nns/governance.did.

Changes

  • extend SwapParameters with missing fields that needs to be displayed for 1-proposal.
  • update deploy_new_sns related types
  • add includeAllManageNeuronProposals param

Tests

Unit tests work.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.84 KB (0%)
@dfinity/cmc 998 B (0%)
@dfinity/ledger 2.51 KB (0%)
@dfinity/nns 30.79 KB (+1.8% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 13.39 KB (0%)
@dfinity/utils 3.74 KB (0%)
@dfinity/rosetta-client -19 B (0%)
@dfinity/ic-management 2.04 KB (0%)

lmuntaner
lmuntaner approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmuntaner
Copy link
Contributor

@mstrasinskis already approved!

@mstrasinskis mstrasinskis marked this pull request as ready for review August 2, 2023 08:20
@mstrasinskis mstrasinskis merged commit 0697cdc into main Aug 2, 2023
9 checks passed
@mstrasinskis mstrasinskis deleted the upgrade-nns-governance-did branch August 2, 2023 08:32
@mstrasinskis mstrasinskis mentioned this pull request Aug 2, 2023
Merged
1 task
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Aug 2, 2023
@mstrasinskis
Upgrade ic js with latest governance (#3015)
e7713c1 
# Motivation

Upgrade ic-js to get latest fields for 1-proposal.
Related to dfinity/ic-js#389

# Changes

- upgrade ic-js to latest next
- set new flag to false

# Tests

Manually tested that the new field is visible.
<img width="612" alt="image"
src="https://github.com/dfinity/nns-dapp/assets/98811342/f6d7c854-1aa8-4413-a4bc-aa614b7b9215">


# Todos

- [x] Add entry to changelog (if necessary).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mstrasinskis @lmuntaner